Skip to content

Align artist parsing with conservative default delimiters#2413

Open
lostf1sh wants to merge 1 commit into
masterfrom
fish/delimiter-issues
Open

Align artist parsing with conservative default delimiters#2413
lostf1sh wants to merge 1 commit into
masterfrom
fish/delimiter-issues

Conversation

@lostf1sh

@lostf1sh lostf1sh commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Narrow the default artist delimiter set to avoid splitting common punctuation inside artist names.
  • Normalize stored legacy delimiter preferences to the new default on read.
  • Reuse the same delimiter logic across cloud imports, album grouping, and metadata updates so display artist selection stays consistent.
  • Add tests covering preserved artist names, legacy preference migration, and feature-heavy album display selection.

Fixed Issues

Related Reports

Testing

  • JAVA_HOME=/usr/lib/jvm/java-21-openjdk PATH=/usr/lib/jvm/java-21-openjdk/bin:$PATH ./gradlew :app:testDebugUnitTest --tests 'com.theveloper.pixelplay.data.worker.ArtistParsingUtilsTest' --tests 'com.theveloper.pixelplay.data.worker.AlbumGroupingUtilsTest' --tests 'com.theveloper.pixelplay.data.preferences.UserPreferencesRepositoryTest' --tests 'com.theveloper.pixelplay.data.stream.CloudMusicUtilsTest'
  • JAVA_HOME=/usr/lib/jvm/java-21-openjdk PATH=/usr/lib/jvm/java-21-openjdk/bin:$PATH ./gradlew :app:assembleDebug :app:installDebug
  • Launched com.theveloper.pixelplay.debug on attached SM-S928B via adb; process stayed running and logcat showed no FATAL EXCEPTION / AndroidRuntime crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant